Casper Hornstrup wrote:
>>>>-----Original Message-----
>>From: ros-dev-bounces at reactos.org [mailto:ros-dev-bounces at reactos.org] On Behalf Of Alex Ionescu
>>Sent: 15. november 2005 21:36
>>To: ReactOS Development List
>>Subject: Re: [ros-dev] RE: [ros-diffs] [cwittich] 19254: add a check forSPDRP_CONFIGFLAGSwhich is
>>not working yet
>>>>While your points are valid, newdev is his baby and he should be allowed
>>to do with it as he damn well pleases. Don't tell me you've never done
>>this kind of operation locally on your disk? Christopher just chose to
>>commit it. It's why I now run a local branch and only commit final code;
>>it lets me do what I want with code that I wrote 100% of, without being
>>criticzed about design choices before the application is complete.
>>>>Note: If this wasn't his app or was a really old app we depend on, I
>>would agree with you. But as far as I'm concerned this is his
>>application and for now there's no point in reviewing it until he
>>considers it done and ready for review.
>>>>Best regards,
>>Alex Ionescu
>>>>>>No way. Contributing something doesn't give you any more right over it than
>anyone else in the community (except copyright).
>I did not argue against that.
>If someone can't accept that,
>then they shouldn't contribute to a community effort like ReactOS.
>I agree.
>If newdev
>is Christopher's "baby", then ntoskrnl must be David's "baby". So what were
>you doing in David's code?
>>He abandonned his code and it needed a new maintainer. I think you're
(purposedly) confusing "maintaining" and "owning" while trying to make a
point which doesn't exist. Ge didn't agree with a change I made in
Freeldr, and I reverted it. Why? Because he's maintaining it and I don't
want to make his life hard. If Magnus spent 6 months writing a DX
library from scratch, does that mean I can come in and rewrite half his
code because I don't like it? No it doesn't. As the maintainer and guy
that wrote 100% of the library he should have a choice in design
decisions made with it. That doesn't mean he has to be Hitler, but it
does give him some authority over his own code.
>I'm sorry to hear that you believe that reviewing is just about critiquing
>someones work
>Never said that.
> and that you are obviously so afraid to answer questions about
>your code that you choose to keep it a secret for as long as possible and
>commit it in big batches.
>>What kind of delluded paranoid argument are you getting into? I never
said any of these things.
>There is very much a point in reviewing as early as possible. It is to find
>bugs as early as possible.
>>I agree and never said anything against this.
>Casper
>>Sometimes I think you like to invent things just to have something to
say. I never said that "I'm afraid to answer questions" or that
"Reviewing is only about critiquing". I pointed out that I find it
stupid and wasteful to make community decisions on something that the
writer hasn't done yet! Imagine a program or DLL as being a book. It
starts out in 3 phases
1) Manuscript being written. At this moment, entire sentences are added
and removed, sometimes 3, 4 times in a row until the author decides what
to do. Entire chapters can disappear. Plot twists can be removed or added.
2) Manuscript is written. The author is happy with his work and thinks
its mostly complete. His editor and publisher will now do reviews, which
can still result in modifications present in the book, sometimes even
major. Sometimes the author might not agree, but usually they are team
decisions, and many times it's mistakes that the author himself hadn't
noticed
3) Published book.
Now when coding with a SVN system, imagine that EVERY sentence
modification in the manuscript is a commit, so therefore becomes a new
manuscript. Do you think that the author sends the editor a new copy
EVERY time he makes a sentence?
Oh yes, I'm starting a book, and my book starts out with "In a butiful
summer afternoon". I send it to the editor. Editor tells me "beautiful,
not butiful." I respond "oh yes, I was really tired that night, I fixed
it a long time ago. Here is a new come: "In a beautiful summer
afternoon, Jake went to the store". Editor responds "Well, you didn't
tell us about Jake yet!". Author says "Yes, I didn't write his character
in yet, here is a new copy of the manuscript (which is only 1 line at
this moment) which introduces Jake.."
Are you starting to realize how pathetic and stupid this woudl be?
Society itself would crumble if people worked like this. The same must
apply to code. The coder starts out with his own internal revisions, as
he slowly writes his functions and fixes his bug. r40 might have a 1000
line function, that by r42 the coder decided was useless and removed. If
he had published r40, then everyone would've reviwed it, maybe even made
some helpful comments about it, only to see it gone in r42, because
nobody is in the mind of the coder and can possibly know his ultimate
design. Even when David commited code to the kernel (I checked the
logs), it wasn't 1 line at a time. He commited entire chunks of
functions which already revealed internal testing and decisions he made
during that time. And so does almost anyone committing code.
The difference here is important because it's a difference between
pre-written code, in which constant and progressive changes are needed,
and non-existant code, in which a whole library is written from scratch.
The "small patches and commit every 100 lines" theory does not, and
cannot hold, for something being written from scratch, especially if
you're a top-down developer. It might only work for people that have
already thought of the design for entire months, and start out with
their DllMain and then write the 100 stubs they know they will need. But
most developers don't do that; some are not aware of the potential
issues which might arise. You can have developed your whole program,
only to realize it fails miserable on MP platforms because you never
tested. And this kind of mistake happens even to the best programmers,
sometimes years later. Look at the Audio subsystem in NT. It was
rewritten THREE times, going from 2/3 user mode 1/3 kernel mode to 1/2
user mode 1/2 kernel mode to 100% user mode in Vista. And we're talking
about a company with dedicated teams and years of experience to find
these kinds of design flaws. But it still took them 15 years to realize
it. So don't tell me that a coder can't realize a mistake after only a
month of testing.
That's why I commited ws2_32 as a "large patch". Not because I was
afraid of reviews. I WANT reviews. It's why I had a local SVN branch and
did the kind of diffs that are usually used when modifying a library, so
that if anyone DOES want to peer into my own thoughts and decisgn
decisions, they can. But if they had done that at r1 and started
changing things around, then by r4 all those changes would've been
irrelevant. Or comments like "hey, you didn't think about ..".. Of
course I didn't! I haven't reached that stage in my implementation phase
yet!
I'm sorry for making this so lenghty but I felt very insulted by your
comments which seemed to imply that I hate reviews, that I'm afraid of
them, and I have unusual ideas about FOSS code contributions.
Best regards,
Alex Ionescu
More information about the Ros-dev
mailing list
CHAPTER VII. THE FOUR CLASSES OF SOCIETY. THE FOUR CLASSES OF SOCIETY. "After the herald had given the names of the wrestlers who were to make the first round, the fellows came in. They were dressed without any clothes to speak of, or rather they were quite undressed, with the exception of a cloth around their loins. They came in on opposite sides of the ring, and stood there about five feet apart, each man resting his hands on his knees, and glaring at the other like a wild beast. They[Pg 231] looked more like a pair of tigers than human beings, and for a moment I thought it was not at all unlike what a bull-fight in Spain might be. I turned upon her choking with anger, but her melting beauty rendered me helpless. Black woods were on our left. "Shall we turn in here?" I asked. "None of that with me," he growled. "Do you know who I am, Countess Lalage? I am Leon Lagage, Count of the Holy Roman Empire, and your husband. Incomparable woman, you cannot alter that fact. For better or worse, for richer or poorer, till death do us part!" I have in this way imperfectly indicated a methodical plan of generating a design, as far as words alone will serve, beginning with certain premises based upon a particular work to be performed, and then proceeding to consider in consecutive order the general character of the machine, mode of operation, movements and adjustments, general arrangement, strains, special arrangement, and proportions. ‘Alas! what is life, what is death, what are we, 11th January two best dresses. Commencement was as usual, with a few showers “All right,” agreed Sandy. “Dick, you and I are the ground crew. As soon as you’re ready, Mr. Whiteside, we’ll take hold!” Effects of Walpole's Administration—Formation of the new Ministry—Attitude of the Malcontents—Committee of Inquiry into Walpole's Administration—Walpole's Protectors—Ministerial Measures—Prorogation of Parliament—Disasters of the French—British Division in the Netherlands—Opening of Parliament—The German Mercenaries—Amendment of the Gin Act—George goes to Germany—Stair and De Noailles in Franconia—Stair in a Trap—Bold Resolution of King George—The Battle of Dettingen—Resignation of Stair—Retreat of the French—Negotiations for Peace—Treaty of Worms—Pelham becomes Prime Minister—The Attacks of Pitt on Carteret—Attempted Invasion of England—Its Failure—Progress of the French Arms—Frederick II. invades Bohemia—His Retirement—Resignation of Carteret—Pelham strengthens his Ministry—Death of the Emperor—Campaign in Flanders—Battle of Fontenoy—Campaign of Frederick II.—The Young Pretender's Preparations—Loss of the Elizabeth—Landing in the Hebrides—The Highland Clans join him—The First Brush—Raising of the Standard—Cope's Mistake—He turns aside at Dalwhinnie—Charles makes a Dash for Edinburgh—The March to Stirling—Right of the Dragoons—The "Canter of Coltbridge"—Edinburgh surprised by the Highlanders—Charles marching against Cope—Battle of Prestonpans—Delay in marching South—Discontent of the Highland Chiefs—The Start—Preparations in England—Apathy of the Aristocracy—Arrival of the Duke of Cumberland—Charles crosses the Border—Capture of Carlisle—The March to Derby—Resolution to retreat—"Black Friday"—The Retreat—Recapture of Carlisle—Siege of Stirling—Battle of Falkirk—Retreat to the Highlands—Cumberland's Pursuit—Gradual Collapse of the Highlanders—Battle of Culloden—Termination of the Rebellion—Cruelty of the Duke of Cumberland—Adventures of the Young Pretender—Trials and Executions—Ministerial Crisis. The next morning he was up betimes, and cooked the boys as good a breakfast as he could out of the remainder of his store and what he could get from the hospital, and then gave what was left to whoever came. The comfortable crib, which had cost the Deacon so much labor, had been pre-empted by the Surgeon for some of his weakest patients. "You two step forward one pace," he commanded. "Gentleman, I've got my six. The rest are yours." "Where are you goin'?" he said sternly. Every now and then the crowd would break into the latest rhymings of MacKinnon's poet: A large thicket, at this moment, gave the dusty foot an opportunity of doubling, and, for an instant, diverging from the straightforward course, though it availed him little, he seemed to feel the breath of his pursuer on the back of his neck; his foot sounded as if at his heels; he drew his garment closely around him, turned suddenly to the right, and, bounding from the ground, the next instant a splash was heard in the little river, and the fugitive was safe from his pursuer. HoME明日之后怎么免费刷一级纳米材料
ENTER NUMBET 0018www.elmers.net.cn www.xindaa.com.cn eocc.net.cn ra5.com.cn www.rvqj.com.cn taigoo.net.cn ebaifu.com.cn www.iwru.com.cn www.jqzws.com.cn www.qvze.com.cn